Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Coeval.Attempt#isFailure to Coeval.Attempt#isError #359

Closed
alexandru opened this issue May 2, 2017 · 0 comments
Closed

Rename Coeval.Attempt#isFailure to Coeval.Attempt#isError #359

alexandru opened this issue May 2, 2017 · 0 comments
Assignees
@alexandru
Milestone
2.3.0

Comments

@alexandru
Copy link
Member

The isFailure method on Attempt happened because of Scala's Try.

However we must be consistent with the naming. We either use "failure" or we use "error", because in practice the two are not perfect synonyms. And we standardize on "error" because of MonadError from Cats and because we've been using onError in Task, Coeval and Observable (basically almost everywhere).

Hence isFailure gets renamed to isError and we leave the old method in place with a @deprecated warning, to not break binary compatibility (for now).
@alexandru alexandru added this to the 2.3.0 milestone May 2, 2017
@alexandru alexandru self-assigned this May 2, 2017
@alexandru alexandru mentioned this issue May 2, 2017
Merged
alexandru added a commit that referenced this issue May 2, 2017
@alexandru
2.3 refactorings and deprecations (#357)
256547a 
Issues:

#354: Enable Mima and Unidoc error reporting in Travis build
#355: Add Coeval#run
#356: Add Task#attempt and Coeval#attempt
#358: Deprecate materializeAttempt and dematerializeAttempt on Task and Coeval
#359: Rename Coeval.Attempt#isFailure to Coeval.Attempt#isError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandru alexandru

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@alexandru