New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerialCancelable should not have orderedUpdate #525

Closed
alexandru opened this Issue Jan 14, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Jan 14, 2018

The orderedUpdate operation does not make sense for SerialCancelable and now that there has been a split between OrderedCancelable and MultiAssignCancelable, this op needs to go from SerialCancelable, simplifying the implementation.

@alexandru alexandru added this to the 3.0.0 milestone Jan 14, 2018

@alexandru alexandru self-assigned this Jan 14, 2018

alexandru added a commit that referenced this issue Jan 14, 2018

Fix #517, #525, #526 — remove macros, SerialCancelable.orderedUpdate (#…
…527)

Changes:

- replaces `Future[Ack]` extension methods with plain functions instead of macros
- replaces `Scheduler` extension methods for Scala 2.11 with plain functions instead of macros
- removes `SerialCancelable#orderedUpdate`

Also increases code coverage for `monix.execution.cancelables`.
@alexandru

This comment has been minimized.

Member

alexandru commented Jan 14, 2018

Fixed in PR #527

@alexandru alexandru closed this Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment