New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newtype for Task.Par, using same encoding used in cats-effect #538

Closed
alexandru opened this Issue Jan 17, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@alexandru
Member

alexandru commented Jan 17, 2018

The cats.Parallel instance is defined for cats.Parallel[Task, Task].

This isn't OK, best practice is to define a newtype for that second type parameter.

In my PR on Parallel[IO, ?] I introduced a newtype encoding inspired by alexknvl/newtypes ... we can't depend on that particular project, because (for Cats) it doesn't support Scala 2.10, plus I'm wary introducing dependencies. But we can use the same trick.

To coordinate with PR #536 that's doing the same for Observable.

@alexandru alexandru added this to the 3.0.0 milestone Jan 17, 2018

@Avasil

This comment has been minimized.

Collaborator

Avasil commented Jan 17, 2018

I think I can do it after I'm done with #536

@alexandru

This comment has been minimized.

Member

alexandru commented Jan 17, 2018

@Avasil I was thinking of you 😀 go for it.

@Avasil

This comment has been minimized.

Collaborator

Avasil commented Jan 17, 2018

Yeah, I will have some practice by then :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment