New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable.take(0) shouldn't subscribe to the source at all #541

Closed
alexandru opened this Issue Jan 18, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@alexandru
Member

alexandru commented Jan 18, 2018

January 17, 2018 11:37 PM:

var counter = 0
def inc() ={
  counter += 1
  1
}

val o = Observable.repeatEval( inc() ).take(0)

The fix should be that take(0) should simply return Observable.empty.

Fix should be back-ported to 2.3.x as well.

@alexandru

This comment has been minimized.

Member

alexandru commented Jan 18, 2018

@Avasil can you please do a back-port to 2.3.x as well?

Pull request to series/2.3.x branch.

@alexandru alexandru reopened this Jan 18, 2018

@alexandru

This comment has been minimized.

Member

alexandru commented Jan 18, 2018

Planning a 2.3.3 release with bug fixes.

@alexandru alexandru closed this Jan 18, 2018

@alexandru alexandru modified the milestones: 2.3.3, 2.4.0, 3.0.0 Jan 21, 2018

@Ben-Barron

This comment has been minimized.

Ben-Barron commented Nov 14, 2018

Your recommendation on this page: https://monix.io/api/2.3/monix/reactive/observables/ObservableLike.html for handling groups produced by the groupBy operator which you are not interested in would not work given this change...right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment