Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic observable take until #1016

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@allantl
Copy link
Contributor

allantl commented Sep 8, 2019

Closes #1005

@allantl allantl force-pushed the allantl:feature/take-until-f branch from a238701 to 772c75d Sep 16, 2019
@allantl allantl force-pushed the allantl:feature/take-until-f branch from 772c75d to 90be1c1 Sep 16, 2019
@alexandru

This comment has been minimized.

Copy link
Member

alexandru commented Sep 16, 2019

While you're at it, also change the Observable version. I don't see why not. Shouldn't break source or binary compatibility.

@allantl allantl force-pushed the allantl:feature/take-until-f branch from 9ffa6fd to 90be1c1 Sep 16, 2019
@allantl allantl closed this Sep 16, 2019
@allantl allantl reopened this Sep 16, 2019
@allantl

This comment has been minimized.

Copy link
Contributor Author

allantl commented Sep 16, 2019

Unfortunately, it breaks binary compatibility.
Screenshot 2019-09-16 at 21 27 31

@alexandru

This comment has been minimized.

Copy link
Member

alexandru commented Sep 16, 2019

That's weird but if it's so, revert the Observable version to usage of Any, since it's not an problen anyway and we might deal with it later.

@allantl

This comment has been minimized.

Copy link
Contributor Author

allantl commented Sep 26, 2019

Yeap, its done.

@Avasil
Avasil approved these changes Sep 29, 2019
Copy link
Collaborator

Avasil left a comment

Thank you @allantl
Really appreciate all the contributions :)

@Avasil Avasil merged commit cebdd8c into monix:master Oct 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@allantl allantl deleted the allantl:feature/take-until-f branch Oct 2, 2019
@allantl

This comment has been minimized.

Copy link
Contributor Author

allantl commented Oct 2, 2019

@Avasil My pleasure. I'm happy to help. Thanks for all the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.