Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove task.doOnCancel(cancelComposite) in Observable.mapParallel #1070

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@Avasil
Copy link
Collaborator

Avasil commented Nov 6, 2019

@TapanVaishnav I noticed that doOnCancel(cancelComposite) is redundant because a Task is a part of composite - so if it gets canceled then the other Task will as well.

I didn't want to bother you because of my oversight :D

@Avasil Avasil merged commit c9f2a69 into monix:master Nov 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TapanVaishnav

This comment has been minimized.

Copy link
Contributor

TapanVaishnav commented Nov 6, 2019

@TapanVaishnav I noticed that doOnCancel(cancelComposite) is redundant because a Task is a part of composite - so if it gets canceled then the other Task will as well.

I see

I didn't want to bother you because of my oversight :D

No trouble, I'm ready to help anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.