Skip to content

Bracket should not evaluate "use" if Task was canceled during "acquire" #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Avasil merged 1 commit into from
Dec 13, 2019
Merged

Bracket should not evaluate "use" if Task was canceled during "acquire" #1087

Avasil merged 1 commit into from
Dec 13, 2019

Conversation

@Avasil
Copy link
Collaborator

@Avasil Avasil commented Nov 27, 2019

@Avasil Avasil requested review from alexandru and oleg-py November 27, 2019 13:14
oleg-py
oleg-py approved these changes Nov 27, 2019
View reviewed changes
Copy link
Collaborator

@oleg-py oleg-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Avasil Avasil merged commit f2e9ba8 into monix:master Dec 13, 2019
@Avasil Avasil deleted the bracket-cancel-use branch December 14, 2019 13:25
mdedetrich pushed a commit to mdedetrich/monix that referenced this pull request Mar 28, 2020
@Avasil @mdedetrich
Bracket should not evaluate "use" if Task was canceled during "acquir…
2eb54e5 
…e" (monix#1087)
@iRevive iRevive mentioned this pull request Apr 28, 2020
Closed
@saksmt saksmt mentioned this pull request Jul 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleg-py oleg-py oleg-py approved these changes

@alexandru alexandru Awaiting requested review from alexandru

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avasil @oleg-py