Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable drop long #1098

Merged
merged 3 commits into from Jan 8, 2020
Merged

Observable drop long #1098

merged 3 commits into from Jan 8, 2020

Conversation

gclaramunt
Copy link
Contributor

@gclaramunt gclaramunt commented Dec 15, 2019

See #1072

@Avasil
Copy link
Collaborator

@Avasil Avasil commented Dec 15, 2019

Thanks for PR @gclaramunt sorry for not following up on it earlier

Unfortunately the change is not binary compatible so we can't replace it until 4.x

I don't remember the issue about the overloads, I will try to dig it up

I suppose we are stuck with separate method name unless we can find a way to make it compatible

@gclaramunt
Copy link
Contributor Author

@gclaramunt gclaramunt commented Dec 16, 2019

Ah, sorry I missed the binary check... I'll try to check the issue too, it might not be a big deal.
Otherwise, I'll change it to dropLong

@gclaramunt
Copy link
Contributor Author

@gclaramunt gclaramunt commented Dec 16, 2019

Here are the issues with overloading: https://stackoverflow.com/questions/2510108/why-avoid-method-overloading but I've tested and it doesn't happen with Int and Long (it picks int).
Still, it might be risky ... let me know if you want to got with dropLong or something else

Avasil
Avasil approved these changes Jan 8, 2020
Copy link
Collaborator

@Avasil Avasil left a comment

Ok, let's leave it like this and we will remove it in 4.x. I didn't figure out better way and it shouldn't be too problematic.

@Avasil Avasil merged commit dc31710 into monix:master Jan 8, 2020
1 check passed
@gclaramunt
Copy link
Contributor Author

@gclaramunt gclaramunt commented Jan 8, 2020

cool, thanks! :)

mdedetrich pushed a commit to mdedetrich/monix that referenced this issue Mar 28, 2020
* use long in drop instead of int

* follow contribution guidelines

* use overloading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants