Conversation
|
Thanks for PR @gclaramunt sorry for not following up on it earlier Unfortunately the change is not binary compatible so we can't replace it until I don't remember the issue about the overloads, I will try to dig it up I suppose we are stuck with separate method name unless we can find a way to make it compatible |
|
Ah, sorry I missed the binary check... I'll try to check the issue too, it might not be a big deal. |
|
Here are the issues with overloading: https://stackoverflow.com/questions/2510108/why-avoid-method-overloading but I've tested and it doesn't happen with Int and Long (it picks int). |
Avasil
left a comment
There was a problem hiding this comment.
Ok, let's leave it like this and we will remove it in 4.x. I didn't figure out better way and it shouldn't be too problematic.
|
cool, thanks! :) |
* use long in drop instead of int * follow contribution guidelines * use overloading
See #1072