Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cats-effect to 2.1.0, add SyncEffect instance for Coeval #1117

Merged
merged 3 commits into from Mar 2, 2020

Conversation

oleg-py
Copy link
Collaborator

@oleg-py oleg-py commented Jan 31, 2020

Since cats-effect 2.1.0 drops Scala 2.11, I have to cross-build against different versions of it.

So, SyncEffect[Coeval] is only available in 2.12+.
Also, Resource is now covariant, and it wrecks the inference in pattern-matching that we use to make Iterant and Observable out of Resource. I've changed it to use unchecked matches, but we can also just delegate to resource.allocated instead of recursively decomposing it.

@oleg-py oleg-py requested review from alexandru and Avasil Jan 31, 2020
Avasil
Avasil approved these changes Jan 31, 2020
build.sbt Outdated
ThisBuild/catsEffectVersion := {
CrossVersion.partialVersion(scalaVersion.value) match {
case Some((2, 11)) => "2.0.0"
case _ => "2.1.0"
Copy link
Collaborator

@Avasil Avasil Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case _ => "2.1.0"
case _ => "2.1.1"

@Avasil
Copy link
Collaborator

@Avasil Avasil commented Feb 14, 2020

Seems like there is something wrong with Observable doc, I'm not sure what has changed though

[error] /home/travis/build/monix/monix/monix-reactive/shared/src/main/scala/monix/reactive/observables/CombineObservable.scala:24:1: Could not find any member to link for "cats.NonEmptyParallel".
[error] /** Newtype encoding for an [[Observable]] datatype that has a [[cats.Apply]]
[error] ^
[error] /home/travis/build/monix/monix/monix-reactive/shared/src/main/scala/monix/reactive/Observable.scala:6116:3: Could not find any member to link for "cats.NonEmptyParallel".
[error]   /** [[cats.NonEmptyParallel]] instance for [[Observable]]. */
[error]   ^
[error] two errors found
[error] (Scalaunidoc / doc) Scaladoc generation failed
[error] Total time: 40 s, completed Jan 31, 2020 2:07:43 PM

@Avasil Avasil added this to the 3.2.0 milestone Feb 18, 2020
@Avasil
Copy link
Collaborator

@Avasil Avasil commented Mar 2, 2020

I allowed myself to push to your branch, I don't know why unidoc can't resolve few links on Scala 2.12 but it's fine on 2.13. It should be good enough

@Avasil Avasil merged commit a4f1bff into monix:master Mar 2, 2020
1 check passed
mdedetrich pushed a commit to mdedetrich/monix that referenced this issue Mar 28, 2020
…ix#1117)

* Bump cats-effect to 2.1.0; add SyncEffect instance for Coeval

* Create docs on Scala 2.13

Co-authored-by: Piotr Gawryś <pgawrys2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants