Upgrade cats-effect to 2.1.0, add SyncEffect instance for Coeval #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasil
approved these changes
Jan 31, 2020
Avasil
reviewed
Feb 14, 2020
build.sbt
Outdated
| ThisBuild/catsEffectVersion := { | ||
| CrossVersion.partialVersion(scalaVersion.value) match { | ||
| case Some((2, 11)) => "2.0.0" | ||
| case _ => "2.1.0" |
Collaborator
There was a problem hiding this comment.
Suggested change
| case _ => "2.1.0" | |
| case _ => "2.1.1" |
Collaborator
|
Seems like there is something wrong with |
Collaborator
|
I allowed myself to push to your branch, I don't know why |
mdedetrich
pushed a commit
to mdedetrich/monix
that referenced
this pull request
Mar 28, 2020
…ix#1117) * Bump cats-effect to 2.1.0; add SyncEffect instance for Coeval * Create docs on Scala 2.13 Co-authored-by: Piotr Gawryś <pgawrys2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cats-effect 2.1.0 drops Scala 2.11, I have to cross-build against different versions of it.
So, SyncEffect[Coeval] is only available in 2.12+.
Also, Resource is now covariant, and it wrecks the inference in pattern-matching that we use to make Iterant and Observable out of Resource. I've changed it to use unchecked matches, but we can also just delegate to
resource.allocatedinstead of recursively decomposing it.