Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mapConcat to concatMapIterable #1125

Merged
merged 1 commit into from Feb 15, 2020

Conversation

Avasil
Copy link
Collaborator

@Avasil Avasil commented Feb 14, 2020

cc @fchaillou @allantl

I'm still wondering about mapConcat alias for consistency with Akka Streams but we should follow rx as the first priority

@fchaillou
Copy link
Contributor

@fchaillou fchaillou commented Feb 14, 2020

It looks good to me, and after sleeping on it a few days, I think it makes more sense to keep consistency with the rest of the Monix.

@Avasil Avasil merged commit 09ba58d into monix:master Feb 15, 2020
1 check passed
@Avasil Avasil deleted the rename-mapConcat-to-flatMapIterable branch Mar 2, 2020
mdedetrich pushed a commit to mdedetrich/monix that referenced this issue Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants