Deprecate gather, gatherN, gatherUnordered in favor of parSequence, parSequenceN, parSequenceUnordered #1145
Conversation
|
@Avasil @oleg-py @alexandru |
jozic
changed the title
jozic
changed the title
There was a problem hiding this comment.
Thanks @jozic - I think it looks great!
I added one comment about location of depreacted methods and we also have to make it compile / pass mimaReportBinaryIssues check:
- We have benchmark module for a previous version as well so we have to either keep using
gatheror temporarily turn off its compilation in CI (at the top ofbuild.sbtnamed asbenchmarksPrev) - We need to add filters to
MimaFiltersfor renamed objects with implementations. They are private so it's ok. It can be verified withevalJVM/mimaReportBinaryIssues
| @@ -3517,36 +3517,46 @@ object Task extends TaskInstancesLevel1 { | |||
| implicit bf: BuildFrom[M[A], B, M[B]]): Task[M[B]] = | |||
| TaskSequence.traverse(in, f)(bf) | |||
|
|
|||
| /** Alias for [[parSequence]] */ | |||
| @deprecated("Use parSequence", "3.2.0") | |||
| def gather[A, M[X] <: Iterable[X]](in: M[Task[A]])(implicit bf: BuildFrom[M[Task[A]], A, M[A]]): Task[M[A]] = | |||
There was a problem hiding this comment.
We should put deprecated methods to TaskDeprecated.Companion to clean normal API
There is also slightly different convention for description with
/**
* DEPRECATED — please use XXX
*/
…arSequenceN, parSequenceUnordered
|
@Avasil thanks for feedback! Please check it out again |
|
@jozic Looks good, we can add the rest 👍 I think we can wait with |
…arTraverseN, parTraverseUnordered
|
@Avasil I've added second commit with changes for |
addresses #1130