Added collect signature for Consumer companion object (#1151) #1152
Conversation
Avasil
left a comment
Avasil
left a comment
There was a problem hiding this comment.
Thanks, I've left some comments but it looks great!
monix-reactive/shared/src/main/scala/monix/reactive/Consumer.scala
Outdated
Show resolved
Hide resolved
monix-reactive/shared/src/main/scala/monix/reactive/Consumer.scala
Outdated
Show resolved
Hide resolved
monix-reactive/shared/src/main/scala/monix/reactive/Consumer.scala
Outdated
Show resolved
Hide resolved
| * WARNING: For infinite streams the process will eventually | ||
| * blow up with an out of memory error. | ||
| */ | ||
| def toListL[A]: Consumer[A, List[A]] = |
There was a problem hiding this comment.
L is only used in Observable to differentiate between methods returning Task and Observable, I would leave just toList in Consumer. Sorry for nitpick :D
There was a problem hiding this comment.
No worries, I have changed that already :)
| assert(s.state.tasks.isEmpty, "TestScheduler should have no pending tasks") | ||
| } | ||
|
|
||
| test("should return the same all consumed elements as a sequence") { implicit s => |
There was a problem hiding this comment.
I think it needs s.tick() for tests to pass and it's good to merge :)
There was a problem hiding this comment.
thought it was passing already...
is there a better way of running minitests than "sbt project reactiveTests" andThen "sbt test"?
There was a problem hiding this comment.
ReactiveTests is something else but I can see how it is confusing :D
reactiveJVM/testor
reactiveJVM/testOnly *NameOfTheTestClass
2 participants
No description provided.