Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'MatchError: null' in Iterant.fromReactivePublisher #1181

Merged

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented May 13, 2020

Iterant.fromReactivePublisher could encounter MatchError: null if the publisher completed the subscription (or I supposed raised an error) before the subscriber could have been initialised.

The PR introduces an Uninitialized state to make sure the individual methods matching on it handle the situation.

Fixes #1180

Copy link
Member

@alexandru alexandru left a comment

On a cursory look this is good. If that test captures the error then I'm 👍

Avasil
Avasil approved these changes May 17, 2020
Copy link
Collaborator

@Avasil Avasil left a comment

Thank you for a bug fix!

Let me know if you need a snapshot release.
We have done a release recently so I'd rather include more fixes before doing the next "official" one but I've set up a milestone to track it: https://github.com/monix/monix/milestone/25

@Avasil Avasil merged commit ec75ebc into monix:3.0.0 May 17, 2020
1 check passed
@Avasil
Copy link
Collaborator

Avasil commented May 17, 2020

Oh, I have just noticed after the fact that the PR targets monix:3.0.0 branch instead of master - would you mind submitting PR again?

@alexandru
Copy link
Member

alexandru commented May 17, 2020

Do we need a monix:3.0.0 branch btw?

It's a little confusing, we should probably delete it.

@aakoshh aakoshh deleted the fix-matcherror-null-iterant-fromreactivepublisher branch Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants