Fix 'MatchError: null' in Iterant.fromReactivePublisher #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandru
approved these changes
May 13, 2020
Member
alexandru
left a comment
alexandru
left a comment
There was a problem hiding this comment.
On a cursory look this is good. If that test captures the error then I'm 👍
Avasil
approved these changes
May 17, 2020
Collaborator
There was a problem hiding this comment.
Thank you for a bug fix!
Let me know if you need a snapshot release.
We have done a release recently so I'd rather include more fixes before doing the next "official" one but I've set up a milestone to track it: https://github.com/monix/monix/milestone/25
Collaborator
|
Oh, I have just noticed after the fact that the PR targets |
Member
|
Do we need a It's a little confusing, we should probably delete it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterant.fromReactivePublishercould encounterMatchError: nullif the publisher completed the subscription (or I supposed raised an error) before the subscriber could have been initialised.The PR introduces an
Uninitializedstate to make sure the individual methods matching on it handle the situation.Fixes #1180