Remove blocking around reading each element#1184
Merged
Avasil merged 1 commit intoMay 15, 2020
Merged
Conversation
…le, InputStreamObservable and LinesReaderObservable because it has big performance overhead
Member
|
Oh wow, thanks @vasily-kirichenko for spotting this! |
alexandru
approved these changes
May 15, 2020
Avasil
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
blockingaround reading each element in CharsReaderObservable, InputStreamObservable and LinesReaderObservable because it has a big performance overhead.In a test that reads 3GB, 95M lines file
LinesReaderObservabledid ~400K lines per seconds before this fix, and ~7M lines per second after the fix (~17 times faster).