Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blocking around reading each element #1184

Merged
merged 1 commit into from May 15, 2020

Conversation

vasily-kirichenko
Copy link
Contributor

@vasily-kirichenko vasily-kirichenko commented May 15, 2020

Removed blocking around reading each element in CharsReaderObservable, InputStreamObservable and LinesReaderObservable because it has a big performance overhead.

In a test that reads 3GB, 95M lines file LinesReaderObservable did ~400K lines per seconds before this fix, and ~7M lines per second after the fix (~17 times faster).

…le, InputStreamObservable and LinesReaderObservable because it has big performance overhead
@alexandru
Copy link
Member

alexandru commented May 15, 2020

Oh wow, thanks @vasily-kirichenko for spotting this!

Avasil
Avasil approved these changes May 15, 2020
@Avasil Avasil merged commit d77a825 into monix:master May 15, 2020
1 check passed
@vasily-kirichenko vasily-kirichenko deleted the fix-too-fine-graned-blocking branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants