Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1177: Fix doAfterSubscribe popping cancelables in the wrong order #1187

Merged
merged 1 commit into from May 26, 2020

Conversation

Avasil
Copy link
Collaborator

@Avasil Avasil commented May 22, 2020

Fixes #1177

@@ -103,7 +103,7 @@ private[reactive] object DoOnSubscribeObservable {
)

val ref = SingleAssignCancelable()
val conn = StackedCancelable(List(cancelable, ref))
val conn = StackedCancelable(List(ref, cancelable))
Copy link
Collaborator Author

@Avasil Avasil May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is popped when task finishes running but StackedCancelable works in FIFO order so it was removing cancelable

@Avasil Avasil merged commit e152376 into monix:master May 26, 2020
1 check passed
@Avasil Avasil deleted the doOnSubscribe-cancel-issue branch Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant