New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1177: Fix doAfterSubscribe popping cancelables in the wrong order #1187

Merged

Avasil merged 1 commit into monix:master from Avasil:doOnSubscribe-cancel-issue

May 26, 2020

Collaborator

Avasil commented May 22, 2020

Fixes #1177


          monix#1177: doOnSubscriptionCancel not executed in combination with d…

76878cc

…oAfterSubscribe

Avasil commented

View reviewed changes

...active/shared/src/main/scala/monix/reactive/internal/operators/DoOnSubscribeObservable.scala

@@ @@ -103,7 +103,7 @@ private[reactive] object DoOnSubscribeObservable { @@
                     )
                     val ref = SingleAssignCancelable()
-                    val conn = StackedCancelable(List(cancelable, ref))
+                    val conn = StackedCancelable(List(ref, cancelable))

Collaborator Author

Avasil May 22, 2020

It is popped when task finishes running but StackedCancelable works in FIFO order so it was removing cancelable

Avasil merged commit e152376 into monix:master

Avasil deleted the doOnSubscribe-cancel-issue branch

November 14, 2020 15:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet