Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings back transformer (#891) #1209

Merged
merged 3 commits into from Jul 26, 2020
Merged

Conversation

paualarco
Copy link
Member

Brings back transform signature and type Transformer[+A, -B] = Observable[A] => Observable[B].

Some extra motivations of this PR are that the current monix-dynamodb already exposes this operator in its api, and it is also shown in the documentation, which could create confusions.

Avasil
Avasil approved these changes Jul 2, 2020
@Avasil
Copy link
Collaborator

Avasil commented Jul 7, 2020

I'm wondering where to put the alias - Observable companion object or reactive package object

@paualarco
Copy link
Member Author

paualarco commented Jul 7, 2020

I'm wondering where to put the alias - Observable companion object or reactive package object

It might be more intuitive to put it in the reactive package.
And that should also apply to Operator[-I, +O], don't you think?

@Avasil
Copy link
Collaborator

Avasil commented Jul 7, 2020

I think it's fine for Operator because it is mostly used internally anyway and moving it would break compatibility

@paualarco
Copy link
Member Author

I'm wondering where to put the alias - Observable companion object or reactive package object

Will address the change whenever there is a final decision :-)

@alexandru alexandru merged commit 37ad3e0 into monix:master Jul 26, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants