Skip to content

Brings back transformer (#891) - #1209

Merged
alexandru merged 3 commits into
monix:masterfrom
paualarco:feature/transformer
Jul 26, 2020
Merged

Brings back transformer (#891)#1209
alexandru merged 3 commits into
monix:masterfrom
paualarco:feature/transformer

Conversation

@paualarco

Copy link
Copy Markdown
Member

Brings back transform signature and type Transformer[+A, -B] = Observable[A] => Observable[B].

Some extra motivations of this PR are that the current monix-dynamodb already exposes this operator in its api, and it is also shown in the documentation, which could create confusions.

Comment thread monix-reactive/shared/src/main/scala/monix/reactive/Observable.scala Outdated
@Avasil

Avasil commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

I'm wondering where to put the alias - Observable companion object or reactive package object

@paualarco

paualarco commented Jul 7, 2020

Copy link
Copy Markdown
Member Author

I'm wondering where to put the alias - Observable companion object or reactive package object

It might be more intuitive to put it in the reactive package.
And that should also apply to Operator[-I, +O], don't you think?

@Avasil

Avasil commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

I think it's fine for Operator because it is mostly used internally anyway and moving it would break compatibility

@paualarco

Copy link
Copy Markdown
Member Author

I'm wondering where to put the alias - Observable companion object or reactive package object

Will address the change whenever there is a final decision :-)

Comment thread monix-reactive/shared/src/main/scala/monix/reactive/Observable.scala Outdated
@alexandru
alexandru merged commit 37ad3e0 into monix:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants