Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Observable#bufferWhile and bufferWhileInclusive #1265

Merged
merged 3 commits into from Sep 24, 2020

Conversation

Avasil
Copy link
Collaborator

@Avasil Avasil commented Sep 12, 2020

Fixes #1260

val toEmit = buffer.append(elem).toList
buffer = ListBuffer.empty
ack = out.onNext(toEmit)
} else if (buffer.nonEmpty) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure if we should emit empty buffer if it's false for the first element, or not

@Avasil Avasil merged commit 4d6e907 into monix:series/3.x Sep 24, 2020
@Avasil Avasil deleted the Observable#bufferWhile branch November 14, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Observable.bufferWhile and bufferWhileInclusive
1 participant