Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapEval, tapError methods at Task and Coeval #1291

Merged
merged 1 commit into from Oct 9, 2020

Conversation

GKhotyan
Copy link
Contributor

@GKhotyan GKhotyan commented Oct 9, 2020

#1279
I thought about tapEval and flatTap. In my humble opinion, seems that tapEval is better here

Avasil
Avasil approved these changes Oct 9, 2020
Copy link
Collaborator

@Avasil Avasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
Would you mind creating a PR to rename flatTap to tapEval in monix-bio?

@GKhotyan
Copy link
Contributor Author

GKhotyan commented Oct 9, 2020

Great, thank you!
Would you mind creating a PR to rename flatTap to tapEval in monix-bio?

Yes, sure. I'll make it in monix-bio

@Avasil Avasil merged commit 37c0bce into monix:series/3.x Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants