Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing no-op onComplete() call from onNext() #1293

Merged
merged 1 commit into from
Oct 13, 2020
Merged

removing no-op onComplete() call from onNext() #1293

merged 1 commit into from
Oct 13, 2020

Conversation

jyoo980
Copy link
Contributor

@jyoo980 jyoo980 commented Oct 12, 2020

Should resolve #1277

Avasil
Avasil approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@Avasil Avasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@Avasil Avasil merged commit b5bc149 into monix:series/3.x Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avasil Avasil Avasil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TakeLeftByTimespanObservable should not call onComplete in onNext
2 participants
@jyoo980 @Avasil