fromIteratorBuffered#1307
Merged
Merged
Conversation
|
@Avasil Actually it might be even more then this number in my use-case because the JDBC ResultSet fetches results in a chunked way itself. That means that by synchronizing Monix Chunks and JDBC chunks, we might be freeing a whole lot of IO cycles downstream. Will let you know how it turns out. Btw what release can I hope to see this in? |
Collaborator
Author
|
@deusaquilus It's already released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1275
I've run a simple benchmark against
fromIterator+bufferSlidingand there seems to be a decent gain (around 35%, perhaps more than 3.2.2 because we fixed perf regression on Scala 2.13) but I'm not sure if it is enough to make a difference for your use case @deusaquilusIf it's not, I'm happy to try and help to solve the issue