Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 (Dotty) support #1323

Merged
merged 20 commits into from May 10, 2021
Merged

Scala 3 (Dotty) support #1323

merged 20 commits into from May 10, 2021

Conversation

larsrh
Copy link
Contributor

@larsrh larsrh commented Nov 20, 2020

@larsrh larsrh mentioned this pull request Nov 20, 2020
7 tasks
@larsrh larsrh changed the title update build for Dotty Dotty support Nov 20, 2020
@larsrh larsrh force-pushed the wip/dotty branch 5 times, most recently from eb5e75f to 0cef70d Compare November 23, 2020 20:43
@larsrh
Copy link
Contributor Author

larsrh commented Dec 6, 2020

There a still four compile errors in the doctest reactiveJVM:

[error] -- Error: /home/lars/proj/monix/monix/monix-reactive/jvm/target/scala-3.0.0-M1/src_managed/test/monix/reactive/ObservableDoctest.scala:446:11 
[error] 446 |    ).merge
[error]     |           ^
[error]     |no implicit argument of type monix.reactive.OverflowStrategy[B] was found for parameter os of method merge in class Observable

I find that strange; I thought the type ascription to the implicit argument of merge fixed these.

@Avasil
Copy link
Collaborator

Avasil commented Dec 6, 2020

There a still four compile errors in the doctest reactiveJVM:

[error] -- Error: /home/lars/proj/monix/monix/monix-reactive/jvm/target/scala-3.0.0-M1/src_managed/test/monix/reactive/ObservableDoctest.scala:446:11 
[error] 446 |    ).merge
[error]     |           ^
[error]     |no implicit argument of type monix.reactive.OverflowStrategy[B] was found for parameter os of method merge in class Observable

I find that strange; I thought the type ascription to the implicit argument of merge fixed these.

I've opened an issue about it lampepfl/dotty#10497

@larsrh
Copy link
Contributor Author

larsrh commented Dec 6, 2020

I've opened an issue about it

Ah right, I forgot that existed 😁

@Avasil
Copy link
Collaborator

Avasil commented May 4, 2021

@larsrh I have finally spent some time on it and the good news is that almost all tests pass! I think the only issue left is Observable#merge...

@alexandru alexandru marked this pull request as ready for review May 7, 2021 07:53
@alexandru alexandru changed the title Dotty support Scala 3 (Dotty) support May 7, 2021
@alexandru alexandru marked this pull request as draft May 7, 2021 10:09
@alexandru alexandru marked this pull request as ready for review May 7, 2021 11:40
@alexandru
Copy link
Member

I solved merge by fixing the tests 🤷‍♂️ as there's nothing we can do for now, the only other options being:

  1. to wait for that bug to get fixed in Scala 3, or ...
  2. break compatibility

We can break compatibility in 4.0.0, but for now this will have to do.


I also upgraded sbt, and cleaned up all warnings, except for those weird ones that aren't reported as actual warnings and that may be the result of some plugin.

Not sure if I want to do anything else before merging.

@larsrh
Copy link
Contributor Author

larsrh commented May 7, 2021

Please hold back with merging until I get the chance to do one final review pass, okay?

@alexandru
Copy link
Member

@larsrh sounds good, thanks!

Copy link
Collaborator

@oleg-py oleg-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor Author

@larsrh larsrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted a few issues where there are inconsistencies between Scala 2 and 3 and (possibly?) unrelated changes that I don't understand. But those aren't blockers. Good work, everyone 💪

@alexandru alexandru merged commit 651e7da into series/3.x May 10, 2021
@alexandru alexandru deleted the wip/dotty branch May 10, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants