Scala 3 (Dotty) support - #1323
Conversation
eb5e75f to
0cef70d
Compare
|
There a still four compile errors in the doctest I find that strange; I thought the type ascription to the implicit argument of |
I've opened an issue about it scala/scala3#10497 |
Ah right, I forgot that existed 😁 |
# Conflicts: # project/plugins.sbt
# Conflicts: # .github/workflows/build.yml
|
@larsrh I have finally spent some time on it and the good news is that almost all tests pass! I think the only issue left is |
|
I solved
We can break compatibility in 4.0.0, but for now this will have to do. I also upgraded sbt, and cleaned up all warnings, except for those weird ones that aren't reported as actual warnings and that may be the result of some plugin. Not sure if I want to do anything else before merging. |
|
Please hold back with merging until I get the chance to do one final review pass, okay? |
|
@larsrh sounds good, thanks! |
larsrh
left a comment
There was a problem hiding this comment.
I noted a few issues where there are inconsistencies between Scala 2 and 3 and (possibly?) unrelated changes that I don't understand. But those aren't blockers. Good work, everyone 💪
Collaborative PR: @alexandru @Avasil @larsrh
Prequel PRs:
Schedulerextension methods, move them toScheduler#1327SchedulerServiceextension methods #1328JSArrayQueue#1329