Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2/3 compatiblity #1326

Merged
merged 3 commits into from
Nov 21, 2020
Merged

Scala 2/3 compatiblity #1326

merged 3 commits into from
Nov 21, 2020

Conversation

larsrh
Copy link
Contributor

@larsrh larsrh commented Nov 21, 2020

This PR contains syntactic changes in the monix-execution module that could be adopted regardless of Dotty.

case IsCanceled | IsEmptyCanceled => ()
case IsActive(s) =>
state.set(IsCanceled)
if (extra != null) extra.cancel()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dotty complains about this call, which is working as intended: scala/scala3#9054

@larsrh larsrh mentioned this pull request Nov 21, 2020
6 tasks
@larsrh larsrh requested a review from Avasil November 21, 2020 14:21
@Avasil Avasil merged commit 23e4d7d into monix:series/3.x Nov 21, 2020
@larsrh larsrh deleted the dotty-compat/syntax branch November 23, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants