deprecate Scheduler extension methods, move them to Scheduler
#1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsrh
commented
Nov 21, 2020
Comment on lines
+27
to
29
| @deprecated("Use `execute` directly, since Scala 2.11 support has been dropped", "3.4.0") | ||
| def executeAsync(cb: Runnable): Unit = | ||
| source.execute(cb) |
Contributor
Author
There was a problem hiding this comment.
I did not create an executeAsync method directly on Scheduler, because some subclass of Scheduler defines a protected def executeAsync with the exact same signature. I left this one in place, but deprecated it, and replaced all calls that do not directly call the subclass method.
Avasil
approved these changes
Nov 22, 2020
Collaborator
Avasil
left a comment
Avasil
left a comment
There was a problem hiding this comment.
Good to see executeAsync ambiguity improved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotty does not trigger
implicit classes for extension methods that overload existing methods.