Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing method implementation to JSArrayQueue #1329

Merged
merged 1 commit into from
Nov 22, 2020
Merged

add missing method implementation to JSArrayQueue #1329

merged 1 commit into from
Nov 22, 2020

Conversation

larsrh
Copy link
Contributor

@larsrh larsrh commented Nov 22, 2020

This implementation was missing in JSArrayQueue. Inexplicably, Dotty complained, whereas Scala 2 didn't see a problem:

[error] -- Error: /home/lars/proj/monix/monix/monix-execution/js/src/main/scala/monix/execution/internal/collection/JSArrayQueue.scala:28:27 
[error] 28 |private[monix] final class JSArrayQueue[A] private (_size: Int, triggerEx: Int => Throwable = null)
[error]    |                           ^
[error]    |class JSArrayQueue needs to be abstract, since def size: => Int is not defined 

@larsrh larsrh requested a review from Avasil November 22, 2020 12:53
@larsrh larsrh mentioned this pull request Nov 22, 2020
6 tasks
@Avasil Avasil merged commit 784fce1 into monix:series/3.x Nov 22, 2020
@larsrh larsrh deleted the dotty-compat/override branch November 22, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants