Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute an Action (() => Unit) #200

Merged
merged 3 commits into from Aug 10, 2016

Conversation

Projects
None yet
3 participants
@aoprisan
Copy link
Contributor

commented Aug 2, 2016

Added an execute overload which takes an Action (() => Unit), wraps it in RunnableAction and forwards it to the default execute method.

execute an Action (() => Unit)
fixed comment

@alexandru alexandru changed the title execute an Action (() => Unit) Execute an Action (() => Unit) Aug 10, 2016

@codecov-io

This comment has been minimized.

Copy link

commented Aug 10, 2016

Current coverage is 83.74% (diff: 0.00%)

No coverage report found for master at 12597dd.

Powered by Codecov. Last update 12597dd...10460c1

@alexandru

This comment has been minimized.

Copy link
Member

commented Aug 10, 2016

  • changed name, because this particular override is problematic as it can conflict with the main method, because of that by-name parameter - in all other cases the arity of the methods are different and so you can't end up with a conflict - this is related to by-name params, I would have been fine with a Function1, but then that wouldn't have been consistent
  • added a simple test

@alexandru alexandru merged commit 56baaee into master Aug 10, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@alexandru alexandru deleted the schedulerExecuteAction branch Nov 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.