Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task improvements #202

Merged
merged 1 commit into from Aug 8, 2016

Conversation

Projects
None yet
1 participant
@alexandru
Copy link
Member

alexandru commented Aug 8, 2016

Some task improvements:

  • For Callback, removed the popBeforeCall and async builders, because they were confusing
  • Instead Callback now has asyncOnSuccess and asyncOnError specified as extension methods (not methods on the class)
  • Task.create was changed to be safe, in that users are protected from stack-overflows on usage of onSuccess - this isn't always a good solution for performance reasons, but users knowing what they are doing always have unsafeCreate
  • Optimized chooseFirstOfList and ensured its stack safe - as part of it the implementation of CompositeCancelable was replaced with one that uses an internal mutable HashSet
  • Optimized TestScheduler and as a result some tests are running dramatically faster

@alexandru alexandru added this to the 2.0 milestone Aug 8, 2016

@alexandru alexandru self-assigned this Aug 8, 2016

@alexandru alexandru merged commit 12597dd into master Aug 8, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@alexandru alexandru deleted the task-improvements branch Nov 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.