Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniquely name threads generated from ThreadFactory #208

Merged
merged 1 commit into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@lukestephenson
Copy link
Contributor

lukestephenson commented Aug 15, 2016

Fixes #204

@lukestephenson lukestephenson force-pushed the lukestephenson:uniquely-named-threads branch from 652f87b to afe54a1 Aug 15, 2016

@lukestephenson

This comment has been minimized.

Copy link
Contributor Author

lukestephenson commented Aug 16, 2016

Not sure why the PR build is failing. sbt test locally runs fine.

@alexandru

This comment has been minimized.

Copy link
Member

alexandru commented Aug 16, 2016

Thanks @lukestephenson, looks good. Don't worry about the tests. The tests suite contain some things that depend on timeouts and it's quite resource intensive, so they can trigger errors in Travis. Quite annoying, will probably have to tune those timeouts.

@lukestephenson

This comment has been minimized.

Copy link
Contributor Author

lukestephenson commented Aug 17, 2016

Thanks @alexandru - when do you plan to merge this?

@alexandru alexandru merged commit ac67ac9 into monix:master Aug 17, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.