New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monad[CancelableFuture] #395

Merged
merged 1 commit into from Aug 5, 2017

Conversation

Projects
None yet
2 participants
@larsrh
Contributor

larsrh commented Aug 5, 2017

Fixes #394

@codecov

This comment has been minimized.

codecov bot commented Aug 5, 2017

Codecov Report

Merging #395 into master will decrease coverage by 0.1%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   88.26%   88.15%   -0.11%     
==========================================
  Files         337      337              
  Lines        9007     9020      +13     
  Branches     1195     1194       -1     
==========================================
+ Hits         7950     7952       +2     
- Misses       1057     1068      +11
@@ -162,4 +164,10 @@ object CancelableFuture {
override def cancel(): Unit =
cancelable.cancel()
}
implicit def cancelableFutureMonad(implicit ec: ExecutionContext): Monad[CancelableFuture] = new Monad[CancelableFuture] with StackSafeMonad[CancelableFuture] {

This comment has been minimized.

@alexandru

alexandru Aug 5, 2017

Member

I'm trying to have consistent naming and just made some changes, so according to PR #397 we'll now have:

  • Task.catsInstances (implementing Async[Task])
  • Task.catsEffectInstances (implementing Effect[Task], different from above because this one requires a Scheduler)
  • Coeval.catsInstances
  • Observable.catsInstances
  • Iterant.catsInstances

It would be good if this where named catsInstances too.

Also, we should probably implement MonadError[CancelableFuture, Throwable] as well.

This comment has been minimized.

@larsrh

larsrh Aug 5, 2017

Contributor

On it.

This comment has been minimized.

@larsrh

larsrh Aug 5, 2017

Contributor

Done.

@alexandru

This comment has been minimized.

Member

alexandru commented Aug 5, 2017

@larsrh have you committed anything new? I'm still seeing your original commit only.

@larsrh

This comment has been minimized.

Contributor

larsrh commented Aug 5, 2017

Sorry, forgot the -a in git commit --amend. Should be fixed now.

@alexandru alexandru merged commit ff148aa into monix:master Aug 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@larsrh larsrh deleted the larsrh:topic/monad-flatmap branch Aug 6, 2017

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment