New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming in Observable / Iterant #411

Merged
merged 8 commits into from Aug 11, 2017

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Aug 11, 2017

Work on naming consistency:

  • all fold-left-like (including scan and scanEval) operations taking an initial value should have the param named seed
  • all fold-left-like (including scan and scanEval) operations taking a function should name that function op
  • the Eval suffix (e.g. scanEval, mapEval) in the context of Observable should mean that the operator accepts an F[_] that implements Effect[F]
  • the Async suffix (e.g. mapAsync) should no longer be used
    • renamed mapAsync(parallelism: Int) to mapParallelUnordered
    • deleted the mapAsync alias for mapTask
    • renamed the mapAsync function in Consumer as well
@codecov

This comment has been minimized.

codecov bot commented Aug 11, 2017

Codecov Report

Merging #411 into master will increase coverage by <.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   88.36%   88.36%   +<.01%     
==========================================
  Files         338      338              
  Lines        9234     9243       +9     
  Branches     1244     1254      +10     
==========================================
+ Hits         8160     8168       +8     
- Misses       1074     1075       +1

@alexandru alexandru changed the title from Add Iterant.scanEval to Iterant.scanEval; Observable.scanEval, mapEval; converging on naming Aug 11, 2017

@alexandru alexandru changed the title from Iterant.scanEval; Observable.scanEval, mapEval; converging on naming to Task.fromEffect, Iterant.scanEval, Observable.scanEval+mapEval+naming Aug 11, 2017

@alexandru alexandru changed the title from Task.fromEffect, Iterant.scanEval, Observable.scanEval+mapEval+naming to Consistent naming in Observable / Iterant Aug 11, 2017

alexandru added some commits Aug 11, 2017

@alexandru alexandru merged commit 5264e49 into monix:master Aug 11, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment