New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eval): get rid of OnFinish type alias b/c of bad naming #424

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Sep 5, 2017

Small refactoring of Task. The OnFinish type alias doesn't make much sense and it hides the signature of the callback taken by unsafeCreate.

@codecov

This comment has been minimized.

codecov bot commented Sep 5, 2017

Codecov Report

Merging #424 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   88.72%   88.65%   -0.07%     
==========================================
  Files         341      341              
  Lines        9407     9407              
  Branches     1280     1280              
==========================================
- Hits         8346     8340       -6     
- Misses       1061     1067       +6

@alexandru alexandru merged commit eca395b into monix:master Sep 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment