New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reactive): add conversions from Cats to Observable #427

Merged
merged 3 commits into from Sep 6, 2017

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Sep 6, 2017

Adding these builders:

  • Observable.fromEval[A](fa: cats.Eval[A]): Observable[A]
  • Observable.fromEffect[F[_], A](fa: F[A])(implicit F: Effect[F]): Observable[A]
  • Observable.fromIO[A](fa: IO[A]): Observable[A]

The Effect and IO conversions are piggybacking on the Task.fromEffect implementation.

@codecov

This comment has been minimized.

codecov bot commented Sep 6, 2017

Codecov Report

Merging #427 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   88.75%   88.78%   +0.03%     
==========================================
  Files         342      342              
  Lines        9387     9391       +4     
  Branches     1259     1278      +19     
==========================================
+ Hits         8331     8338       +7     
+ Misses       1056     1053       -3

@alexandru alexandru merged commit 1bbb618 into monix:master Sep 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment