New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(execution): CancelableFuture improvements to get rid of memory leaks + utils #431

Merged
merged 9 commits into from Sep 13, 2017

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Sep 13, 2017

Current implementation of flatMap for CancelableFuture leaks memory (on master, not in 2.3.x), due to recent changes.

This PR fixes it and introduces extra utils, like a CancelableFuture.async builder.

alexandru added some commits Sep 12, 2017

feat(eval): refactor Coeval and Task replacing zipMap2,zipMap3...
BREAKING CHANGE - zipMap2, zipMap3...zipMap6 have been renamed:

- in Coeval they've been renamed to map2, map3, ... map6
- in Task they've been renamed to parMap2, parMap3...parMap6,
  while map2, map3...map6 have been introduced

Change breaks source compatibility.
@codecov

This comment has been minimized.

codecov bot commented Sep 13, 2017

Codecov Report

Merging #431 into master will increase coverage by 0.35%.
The diff coverage is 92.02%.

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   88.86%   89.21%   +0.35%     
==========================================
  Files         341      343       +2     
  Lines        9400     9459      +59     
  Branches     1279     1277       -2     
==========================================
+ Hits         8353     8439      +86     
+ Misses       1047     1020      -27

@alexandru alexandru merged commit 23048a0 into monix:master Sep 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment