New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable.mapParallelUnordered needs configurable overflow strategy #441

Merged
merged 2 commits into from Sep 27, 2017

Conversation

Projects
None yet
2 participants
@wogan
Contributor

wogan commented Sep 26, 2017

Fixes #440.

@codecov

This comment has been minimized.

codecov bot commented Sep 26, 2017

Codecov Report

Merging #441 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   89.15%   89.18%   +0.03%     
==========================================
  Files         345      345              
  Lines        9481     9480       -1     
  Branches     1253     1232      -21     
==========================================
+ Hits         8453     8455       +2     
+ Misses       1028     1025       -3
@alexandru

This PR looks good, please fix the indenting issue and then I can merge it.

final def mapParallelUnordered[B](parallelism: Int)(f: A => Task[B]): Observable[B] =
new MapParallelUnorderedObservable[A, B](self, parallelism, f)
final def mapParallelUnordered[B](parallelism: Int)(f: A => Task[B])
(implicit os: OverflowStrategy[B] = OverflowStrategy.Default): Observable[B] =

This comment has been minimized.

@alexandru

alexandru Sep 26, 2017

Member

I don't like this indenting style for params, there's something that annoys me greatly about things that dangle on the right, which is why this codebase doesn't do it. I know IntelliJ IDEA does this by default, but it can be configured to not do it.

Please use normal indentation for this line.

Greg Wogan-Browne

@alexandru alexandru merged commit 29f1ec5 into monix:master Sep 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wogan wogan deleted the wogan:overflow branch Jan 1, 2018

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment