New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where `fromAsyncStateAction` is not safe for user code #473

Merged
merged 1 commit into from Dec 9, 2017

Conversation

Projects
None yet
2 participants
@rfkm
Contributor

rfkm commented Dec 9, 2017

An observable created by fromAsyncStateAction never completes even if a state function returns a failed task since it doesn't propagate its error to downstream.

This might be related to: #380

@alexandru alexandru merged commit 9fcd178 into monix:master Dec 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandru

This comment has been minimized.

Member

alexandru commented Dec 9, 2017

Thanks @rfkm

@alexandru

This comment has been minimized.

Member

alexandru commented Dec 9, 2017

Would you mind backporting your fix to the 2.3.x branch as well?

@rfkm

This comment has been minimized.

Contributor

rfkm commented Dec 9, 2017

@alexandru Thank you for merging! I've created backport PR: #475

@rfkm rfkm deleted the rfkm:patch branch Dec 9, 2017

@alexandru alexandru added the bug label Jan 21, 2018

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment