New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cats 1.0.0 rc2 and cats-effect 0.6 #485

Merged
merged 4 commits into from Dec 25, 2017

Conversation

Projects
None yet
2 participants
@lorandszakacs
Contributor

lorandszakacs commented Dec 23, 2017

Addressing issue #484. Ought to be quite straightforward.

Replaced one single deprecated operation Apply.followedBy with its equivalent, syntactically symbolic, cousin, *>.

@lorandszakacs

This comment has been minimized.

Contributor

lorandszakacs commented Dec 23, 2017

Current failure of the 2.11.11 build, smells of a concurrency bug to me. Since I can't reproduce the failure. Will investigate after I decorate a tree 😄

�[0m[�[0m�[0minfo�[0m] �[0m�[0m�[32mmonix.eval.TaskBlockingSuite�[0m�[0m
2017-12-23 13:54:06,886 Log4j2-TF-1-AsyncLogger[AsyncContext@dc9876b]-1 ERROR An exception occurred processing Appender testbuffer-229 java.lang.NullPointerException
	at scala.collection.mutable.ListBuffer.copy(ListBuffer.scala:444)
	at scala.collection.mutable.ListBuffer.$plus$eq(ListBuffer.scala:171)
	at sbt.internal.util.BufferedAppender.append(BufferedLogger.scala:44)
	at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
       ....

Addendum:
The actual problem is this one test:

[info] monix.execution.schedulers.AsyncSchedulerSuite
[info] - scheduleOnce with delay
[info] - scheduleOnce with delay lower than 1.milli *** FAILED ***
[info]   TimeoutException: Futures timed out after [3 seconds] (AsyncSchedulerSuite.scala:48)

Ran the test on a loop locally, but still can't get it to fail 😟

@alexandru

This comment has been minimized.

Member

alexandru commented Dec 25, 2017

The timeout error in AsyncSchedulerSuite might be a problem due to Travis — when we have actual async tests with timeouts, Travis can be really slow when running the test, leading to errors, which isn't reproducible on our localhost due to our localhost not slowing down the tests. In such cases we can simply increase the timeout.

@lorandszakacs

This comment has been minimized.

Contributor

lorandszakacs commented Dec 25, 2017

@alexandru. I see.

@codecov

This comment has been minimized.

codecov bot commented Dec 25, 2017

Codecov Report

Merging #485 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   90.14%   90.16%   +0.01%     
==========================================
  Files         353      353              
  Lines        8883     8883              
  Branches     1738     1738              
==========================================
+ Hits         8008     8009       +1     
+ Misses        875      874       -1

@alexandru alexandru merged commit 58128b3 into monix:master Dec 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lorandszakacs lorandszakacs deleted the lorandszakacs:upgrade/cats-1.0.0-RC2 branch Dec 26, 2017

@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment