New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iterant.liftF builder for lifting monadic values #503

Merged
merged 3 commits into from Jan 9, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Jan 8, 2018

Closes #487

oleg-py added some commits Dec 26, 2017

@codecov

This comment has been minimized.

codecov bot commented Jan 8, 2018

Codecov Report

Merging #503 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   89.93%   89.97%   +0.03%     
==========================================
  Files         355      355              
  Lines        9251     9253       +2     
  Branches     1786     1774      -12     
==========================================
+ Hits         8320     8325       +5     
+ Misses        931      928       -3
@@ -59,6 +59,20 @@ object IterantBasicSuite extends BaseTestSuite {
assertEquals(f.value, Some(Success(1)))
}
test("Iterant.liftF") { implicit s =>

This comment has been minimized.

@alexandru

alexandru Jan 8, 2018

Member

We probably need a test using ScalaCheck too.

test("any F instance can be lifted) { implicit s =>
  check1 { (fa: IO[Int]) =>
    Iterant[IO].liftF(fa).headOptionL <-> fa.map(Some.apply)
  }
}

Or something along those lines.

@alexandru

This comment has been minimized.

Member

alexandru commented Jan 8, 2018

Thanks @oleg-py, looks good, see my comment on also adding a ScalaCheck-powered test.

Let me know if you need help.

After that we can merge.

@oleg-py

This comment has been minimized.

Collaborator

oleg-py commented Jan 8, 2018

Good idea. Done 😄

@alexandru alexandru merged commit 002537b into monix:master Jan 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment