New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 517, 525, 526 — remove macros, SerialCancelable.orderedUpdate #527

Merged
merged 2 commits into from Jan 14, 2018

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Jan 14, 2018

Fixes #517, #525, #526.

  • replaces Future[Ack] extension methods with plain functions instead of macros
  • replaces Scheduler extension methods for Scala 2.11 with plain functions instead of macros
  • removes SerialCancelable#orderedUpdate

Also increases code coverage for monix.execution.cancelables.

alexandru added some commits Jan 14, 2018

@alexandru alexandru changed the title from Issue 517, 525, 526 — get rid of useless macros, remove SerialCancelable.orderedUpdate to Issue 517, 525, 526 — remove macros, SerialCancelable.orderedUpdate Jan 14, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 14, 2018

Codecov Report

Merging #527 into master will increase coverage by 0.29%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   90.19%   90.48%   +0.29%     
==========================================
  Files         362      362              
  Lines        9451     9609     +158     
  Branches     1829     1826       -3     
==========================================
+ Hits         8524     8695     +171     
+ Misses        927      914      -13

@alexandru alexandru merged commit 7ca7c0d into monix:master Jan 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment