Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Task.forkAndForget #530
@@ Coverage Diff @@ ## master #530 +/- ## ========================================= + Coverage 90.38% 90.4% +0.01% ========================================= Files 362 364 +2 Lines 9610 9629 +19 Branches 1802 1797 -5 ========================================= + Hits 8686 8705 +19 Misses 924 924
Looks good. I'll go ahead and merge it tonight — if by then you can also add the assertion on
lastReportedError that I mentioned above, that's cool, otherwise I'll merge it without it to not drag it any longer.
The tests are sufficient IMO. It's a hard to test operation since you can only observe side effects.