New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable.take(0) shouldn't subscribe to the source at all #543

Merged
merged 2 commits into from Jan 18, 2018

Conversation

Projects
None yet
2 participants
@Avasil
Collaborator

Avasil commented Jan 18, 2018

Fixes #541
I went ahead and also fixed Observable.takeLast(0)

@codecov

This comment has been minimized.

codecov bot commented Jan 18, 2018

Codecov Report

Merging #543 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   90.34%   90.47%   +0.13%     
==========================================
  Files         366      366              
  Lines        9644     9632      -12     
  Branches     1802     1793       -9     
==========================================
+ Hits         8713     8715       +2     
+ Misses        931      917      -14

@alexandru alexandru merged commit 228050d into monix:master Jan 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Avasil Avasil deleted the Avasil:observable#take0bugfix branch Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment