New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task.sleep + Task.delay* deprecations #550

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
1 participant
@alexandru
Member

alexandru commented Jan 19, 2018

Introducing sleep as an effect similar to Task.shift:

object Task {

  def sleep(timespan: FiniteDuration): Task[Unit]
}

Changes:

  • made .delayExecution and .delayResult to be based on sleep + flatMap, simplifying the implementation
  • deprecated delayExecutionWith and delayResultBySelector, because they are trivially expressible by flatMap alone
  • add one implementation file in package internal for sleep, but removed about 4 files

Those 2 methods are deprecated, but @deprecated extension methods are still provided.

@alexandru alexandru added this to the 3.0.0 milestone Jan 19, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 19, 2018

Codecov Report

Merging #550 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage    90.5%   90.45%   -0.05%     
==========================================
  Files         369      366       -3     
  Lines        9737     9657      -80     
  Branches     1824     1829       +5     
==========================================
- Hits         8812     8735      -77     
+ Misses        925      922       -3

@alexandru alexandru merged commit fb8e35c into monix:master Jan 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment