Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Observable.mapParallelOrdered #558
This is my first attempt.
It passes all of the test cases so that looks good but it is pretty likely I've got lost in proper cancelation, cleaning resources etc despite basing implementation on
Things to consider:
I need to come back to this code after I clear my head but in the meantime I'm opening PR so you could see how is my progress. :)
@@ Coverage Diff @@ ## master #558 +/- ## ========================================== - Coverage 90.34% 90.32% -0.02% ========================================== Files 414 415 +1 Lines 11691 11774 +83 Branches 2154 2149 -5 ========================================== + Hits 10562 10635 +73 - Misses 1129 1139 +10
I will come back to it during/after weekend to fix one bug I mentioned (should be easy to fix) and whatever else I find.
Sorry for procrastinating for so long on this one @Avasil.
This implementation is a little complicated, consider that you're using at the same time:
The logic isn't necessarily incorrect, seems to be doing the right thing, but I hope you don't mind if I procrastinate some more
Btw, this operation is one of those issues where if you come up with an original implementation that has reasonable performance, you could probably write a successful academic paper about it
Most of the stuff is the same as unordered version, the difference is
Thanks @alexandru , I've re-merged with master. I was playing with getting rid of