Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue #563 - completeL should handle F[_] errors, mapEval should not #567
Related to #563 — fixed
In case of this loop, it doesn't matter due to the inner workings of the loop being suspended and completely encapsulated. However this isn't an optimization that we can afford to do for operations returning
Therefore, except for operations meant specifically for error handling, like
@@ Coverage Diff @@ ## master #567 +/- ## ========================================== + Coverage 90.57% 90.61% +0.03% ========================================== Files 369 369 Lines 9782 9781 -1 Branches 1841 1857 +16 ========================================== + Hits 8860 8863 +3 + Misses 922 918 -4
@oleg-py Not waiting any longer on this PR, merging it directly to unblock your testing.
Implementation seems fine to me - the internal variable is completely encapsulated.
One note -