New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iterant#sumL method #578

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Jan 29, 2018

Closes #570

This was easy. Although the only type that has Numeric, but not Monoid out of the box is Char.

@codecov

This comment has been minimized.

codecov bot commented Jan 29, 2018

Codecov Report

Merging #578 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   90.62%   90.63%   +0.01%     
==========================================
  Files         369      369              
  Lines        9802     9803       +1     
  Branches     1840     1846       +6     
==========================================
+ Hits         8883     8885       +2     
+ Misses        919      918       -1

@alexandru alexandru merged commit e49040f into monix:master Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandru

This comment has been minimized.

Member

alexandru commented Jan 30, 2018

@oleg-py on Numeric vs Monoid this is true, however it's about familiarity / integration with the standard library. People expect to do .sum on collection types.

@alexandru

This comment has been minimized.

Member

alexandru commented Jan 30, 2018

We already have foldL taking a Monoid, not sure if you've seen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment