New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterant.reduce and headOptionL error handling #579

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Projects
None yet
2 participants
@Avasil
Collaborator

Avasil commented Jan 29, 2018

Fixes #577.

That leaves us with:

final def skipSuspendL(implicit F: Sync[F]): F[Iterant[F, A]]
final def foldRightL[B](b: F[B])(f: (A, F[B], F[Unit]) => F[B])(implicit F: Sync[F]): F[B]

We leave foldRightL as it is, right?

@codecov

This comment has been minimized.

codecov bot commented Jan 29, 2018

Codecov Report

Merging #579 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   90.62%   90.66%   +0.03%     
==========================================
  Files         369      369              
  Lines        9802     9818      +16     
  Branches     1840     1848       +8     
==========================================
+ Hits         8883     8901      +18     
+ Misses        919      917       -2
@alexandru

This comment has been minimized.

Member

alexandru commented Jan 30, 2018

From what I remember for foldRightL the user is in control, including calling stop when the recursion stops, foldRightL describing a loop with that function parameter.

There's nothing we can do because we are not in charge of evaluating earlyStop.

@alexandru alexandru merged commit 1b54bc0 into monix:master Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Avasil Avasil deleted the Avasil:Iterant#reduce-headOption-errorHandling branch Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment