New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle broken nodes in Iterant.skipSuspendL #581

merged 1 commit into from Feb 2, 2018


None yet
2 participants

oleg-py commented Jan 31, 2018

Closes #559.

Per my testing, skipSuspendL too, requires error handling as it has been done for other left folds. Otherwise you could end up with leaked resources due to earlyStop not being called on broken nodes (the unit test I added was failing before).

Unlike other left folds, skipSuspendL returns an Iterant, and so is free to report errors both inside F and Iterant context. Existing code was doing the latter on broken batches / cursors, so I went for consistency and made it handle broken nodes in this way as well (and I don't think anybody would appreciate some errors being inside F and others being reported as Halt).


This comment has been minimized.

codecov bot commented Jan 31, 2018

Codecov Report

Merging #581 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #581      +/-   ##
+ Coverage   90.65%   90.71%   +0.06%     
  Files         370      370              
  Lines        9844     9845       +1     
  Branches     1851     1850       -1     
+ Hits         8924     8931       +7     
+ Misses        920      914       -6

@alexandru alexandru merged commit 2a01ba1 into monix:master Feb 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.


alexandru commented Feb 2, 2018

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment