New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of broken batches/cursors in Iterant.attempt #589

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Feb 14, 2018

I was looking into #580 and I discovered few bits missing from my Iterant.attempt fix. In particular, it didn't handle broken batches and cursors correctly. All unit tests added here for attempt were failing.

@codecov

This comment has been minimized.

codecov bot commented Feb 14, 2018

Codecov Report

Merging #589 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   90.71%   90.74%   +0.02%     
==========================================
  Files         373      373              
  Lines        9889     9904      +15     
  Branches     1847     1849       +2     
==========================================
+ Hits         8971     8987      +16     
+ Misses        918      917       -1
@alexandru

This comment has been minimized.

Member

alexandru commented Feb 14, 2018

Ah, nice, thanks @oleg-py

@alexandru alexandru merged commit 0d43562 into monix:master Feb 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment