New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve strictness of Eq of Iterants / fix doOnFinish on Last #591

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Feb 15, 2018

Closes #580.

Also discovered that Iterant.doOnFinish was behaving incorrectly on Last case: if a handler function throws, the element inside Last would never be emitted. E.g. this was the behavior:

Iterant[IO].lastS(1).doOnFinish(_ => throw dummy).attempt <-> Iterant[IO].of(Left(dummy))

And now it is:

Iterant[IO].lastS(1).doOnFinish(_ => throw dummy).attempt <-> Iterant[IO].of(Right(1), Left(dummy))
@codecov

This comment has been minimized.

codecov bot commented Feb 15, 2018

Codecov Report

Merging #591 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
+ Coverage   90.68%   90.76%   +0.07%     
==========================================
  Files         373      373              
  Lines        9904     9903       -1     
  Branches     1849     1849              
==========================================
+ Hits         8981     8988       +7     
+ Misses        923      915       -8

@alexandru alexandru merged commit 92af0de into monix:master Feb 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment