New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sync & Async instances for Iterant #600

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Feb 25, 2018

Closes #599

I went ahead and implemented Async instance too (under the assumption that callback will only be invoked once, so it just delegates to underlying F). Couldn't do Effect though in a similar way, because signature of runAsync sort-of implies cardinality of 1.

@oleg-py

This comment has been minimized.

Collaborator

oleg-py commented Feb 27, 2018

@alexandru not sure why build fails, could you please take a look?

@alexandru

This comment has been minimized.

Member

alexandru commented Feb 28, 2018

The build is timing out and it can do so in a piece of logic that wasn't timing out before, possibly due to the CPU being very busy (although I don't understand how, because I remember that I disabled testing in parallel, but those settings never worked properly anyway).

The tests for AsyncLaws and SyncLaws might break Travis. We might need to adjust the ScalaCheck parameters in those tests, to generate shorter Iterant values.

@alexandru alexandru merged commit 5bd360b into monix:master Feb 28, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@alexandru

This comment has been minimized.

Member

alexandru commented Feb 28, 2018

One problem are all the stack-safety checks in SyncLaws, which on Travis are a problem due to the limited CPU available.

@alexandru

This comment has been minimized.

Member

alexandru commented Feb 28, 2018

The attempted fix was to disable them when running on top of Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment