New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify custom options on Effect[Task] #634

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Apr 1, 2018

Closes #625.

I'm still thinking providing a default is not a good decision, but it seems we cannot provide an understandable message when implicit Effect is not found.

@codecov

This comment has been minimized.

codecov bot commented Apr 1, 2018

Codecov Report

Merging #634 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   90.99%   90.94%   -0.05%     
==========================================
  Files         377      377              
  Lines       10026    10026              
  Branches     1891     1888       -3     
==========================================
- Hits         9123     9118       -5     
- Misses        903      908       +5

@alexandru alexandru merged commit 9ba401d into monix:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment