New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Coeval.value empty-parens to indicate side effects #639

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
2 participants
@oleg-py
Collaborator

oleg-py commented Apr 6, 2018

We discussed this on gitter some time ago. Coeval#value is now empty-parens, aligning with conventional way to indicate side-effects in Scala.

This does not trigger any warnings or errors. Only if using some kind of linter (e.g. Intellij does that) you will get something shown.

I went ahead and changed pretty much every usage of value to value() in monix codebase too.

@codecov

This comment has been minimized.

codecov bot commented Apr 6, 2018

Codecov Report

Merging #639 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   90.97%   90.96%   -0.01%     
==========================================
  Files         377      377              
  Lines       10027    10027              
  Branches     1886     1879       -7     
==========================================
- Hits         9122     9121       -1     
- Misses        905      906       +1
@alexandru

This comment has been minimized.

Member

alexandru commented Apr 6, 2018

Looks good.

@alexandru alexandru merged commit af8dfee into monix:master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment